Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-portfolio #380

Open
wants to merge 135 commits into
base: main
Choose a base branch
from
Open

project-portfolio #380

wants to merge 135 commits into from

Conversation

lunek1
Copy link

@lunek1 lunek1 commented Apr 19, 2024

Netlify link

https://wondrous-sorbet-b71db8.netlify.app/

Collaborators

Solo

Copy link
Contributor

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Cornelia, some sizes are still not correct. Check for example Tech,Featured Projects headers and body sizes, the sizes should be bigger (32px and 18px). Also I've noticed you're committing every single file, one by one. This makes the commits history unreadable and it's ineffective to detect the changes in the implementation at first glance. It's better to commit all the file changes involved in the style update in one commit, and just write "Update font sizes" for example 👍

@lunek1
Copy link
Author

lunek1 commented May 31, 2024

Hey Cornelia, some sizes are still not correct. Check for example Tech,Featured Projects headers and body sizes, the sizes should be bigger (32px and 18px). Also I've noticed you're committing every single file, one by one. This makes the commits history unreadable and it's ineffective to detect the changes in the implementation at first glance. It's better to commit all the file changes involved in the style update in one commit, and just write "Update font sizes" for example 👍

Hi! Yeah, sorry I was committing every single file because I didn't think I had so many changes to do. I won't do that anymore. Reason I did that was because vscode for some reason wanted to commit over 7000 things and I wasn't sure if that would ruin my project. So I did it in Github instead but realized it will lead to complications. I think I've changed all the font sizes according to the template now. As for the files in the assets folder I'm using them in my ProjectData.jsx so I can't remove those. Please let me know if I've missed anything else. I sooooo want to me done with this one now. 🫠

Btw could you take a look at my weather app? I made changes to it but I haven't gotten any feedback after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants