Skip to content

Conversation

@gittebe
Copy link

@gittebe gittebe commented Sep 22, 2024

Netlify link

https://library-recipes.netlify.app

Collaborators

[gittebe, Anna2024WebDev, gabster94]

gittebe and others added 30 commits September 17, 2024 12:42
Co-authored-by: Anna Hansen <Anna2024WebDev@users.noreply.github.com>
Co-authored-by: Fanny Henriques <Fannyhenriques@users.noreply.github.com>
Co-authored-by: Fanny Henriques <Fannyhenriques@users.noreply.github.com>
Co-authored-by: Gabriella Iofe <iofe.gabriella@gmail.com>
Co-authored-by: Gabriella Iofe <iofe.gabriella@gmail.com>
Co-authored-by: Fanny Henriques <Fannyhenriques@users.noreply.github.com>
Co-authored-by: Gabriella Iofe <iofe.gabriella@gmail.com>
@gittebe gittebe changed the title Easy Peasy Recipes Easy Peasy Recipes (by Anna, Gabriella and Gitte) Sep 22, 2024
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the project!

You have worked really well with functions and conditionals. And from what I can see you have worked well as a team too. Good use of comments in your code files.

One thing, think about why you are sometimes using named functions, and adding them to the event listeners and sometimes you are going with anonymous functions within the event listeners. Both ways are valid and sometimes it can feel verbous to create named functions for everything. But I would suggest, now in the beginning you should stick to one way. Or at least have a discussion about why/why not. This can be somethin you can add in your reflections of the project if you want to. Things like that can be interesting topics for a demo or a talk with a recruiter/ tech interviewer.

Minor thing, <form> doesn't have a valid attribute called for. for can be used on <label> elements,

You've met all requirements, keep up the good work

This week our project was to build a library using arrays as well as DOM manupulations, functions, variables and event handling. Our recipe library page offers options for filtering, sorting, and randomly selecting items.

This project was the first team project as part of the Technigo bootcamp. Working together on the same repository has been a new important experience for us.
We decided on the project together and build a first HTML and CSS together. We worked on the Javascript codes first idividually and explained and discussed them later on.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants