-
Couldn't load subscription status.
- Fork 115
Elina, Estefanny & Mika's Library #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikaeber
wants to merge
14
commits into
Technigo:main
Choose a base branch
from
mikaeber:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on creating a structured and organized library project! 📚 Let's go through some feedback.
HTML/CSS
- Your HTML is straightforward, clean, and uses appropriate tags, which makes it easy to read and understand.
- You've chosen a clean and minimalist design which makes your page nice to look at. Very nice that the dropdown and buttons have a consistent width, padding, font size, and hover effects.
- Just FYI, generally IDs are used for JS and classes for CSS - so don't be afraid to add class names to your elements to be able to style them in CSS.
JavaScript
- The renderBookList is well-defined and has a good function name too 🥳 Great that you're reusing it!
- Interesting to see that you're using map instead of forEach, it works perfectly fine too.
- You're successfully filtering and sorting according to the requirements ⭐
Clean Code
- You're code is generally clean and easy to read, but please be consistent with whether you're using arrow functions or the function keyword
Amazing work, team!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://mikaelinaestefanny-library.netlify.app/
Collaborators
[github-ElinaEH-1 , github-FannyEste-2]