Skip to content

Conversation

@mikaeber
Copy link

@mikaeber mikaeber commented Sep 18, 2024

Netlify link

https://mikaelinaestefanny-library.netlify.app/

Collaborators

[github-ElinaEH-1 , github-FannyEste-2]

@mikaeber mikaeber changed the title Update README.md Elina, Estefanny & Mika's Library Sep 22, 2024
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on creating a structured and organized library project! 📚 Let's go through some feedback.

HTML/CSS

  • Your HTML is straightforward, clean, and uses appropriate tags, which makes it easy to read and understand.
  • You've chosen a clean and minimalist design which makes your page nice to look at. Very nice that the dropdown and buttons have a consistent width, padding, font size, and hover effects.
  • Just FYI, generally IDs are used for JS and classes for CSS - so don't be afraid to add class names to your elements to be able to style them in CSS.

JavaScript

  • The renderBookList is well-defined and has a good function name too 🥳 Great that you're reusing it!
  • Interesting to see that you're using map instead of forEach, it works perfectly fine too.
  • You're successfully filtering and sorting according to the requirements ⭐

Clean Code

  • You're code is generally clean and easy to read, but please be consistent with whether you're using arrow functions or the function keyword

Amazing work, team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants