Skip to content

Sentry with other improvement for 0.1.9 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 26, 2020
Merged

Sentry with other improvement for 0.1.9 #29

merged 7 commits into from
Dec 26, 2020

Conversation

@lamhoangtung
Copy link
Contributor

@lamhoangtung lamhoangtung commented Dec 26, 2020

No description provided.

lamhoangtung and others added 6 commits October 1, 2020 19:07
@lamhoangtung
🐛 Bugs fix and improvement for 0.1.8 (#21)
c8ad8e0 
* Resolve merge conflict

* Compress CSS

* Compressed js

* Compress more html

* Detached SVG and compress final HTML file

* potential fix for #20

* Minor pipeline bug fixed

* Minor coverage test increase
@meocong
🔖 Update mlconfig 🔖
5c3c8cc 
Env var is now on top of priority in mlconfig
@meocong
🚀 🚀 🚀 Update mlchain 0.1.9 🚀 🚀 🚀
7edbe8d 
- Sentry integration. Fixed #28
- Update better interface for mlconfig.yaml
- Put env on the most priority
- Handle some exceptions
@meocong
Update requirements + Fixed sentry when no dsn
a364bf8
@meocong
🐛 Higher Priority for Sentry config using env vars + Fixed requiremen…
00b1db5 
…ts for Python 3.6 🐛
@meocong
🎉 🎉 🎉 Handle exception + Fixed Sentry break Gunicorn + Better default…
cff1f4c 
… config🎉 🎉 🎉
@lamhoangtung lamhoangtung added the enhancement New feature or request label Dec 26, 2020
@lamhoangtung lamhoangtung self-assigned this Dec 26, 2020
@codecov
Copy link

codecov bot commented Dec 26, 2020 •
edited
Loading

Codecov Report

Merging #29 (8f3c1e6) into linus_dev (02bfc83) will increase coverage by 0.68%.
The diff coverage is 59.41%.

Impacted file tree graph

@@              Coverage Diff              @@
##           linus_dev      #29      +/-   ##
=============================================
+ Coverage      54.64%   55.32%   +0.68%     
=============================================
  Files             44       47       +3     
  Lines           3609     3765     +156     
=============================================
+ Hits            1972     2083     +111     
- Misses          1637     1682      +45
Impacted Files Coverage Δ
mlchain/base/serve_model.py 51.68% <ø> (+0.01%) ⬆️
mlchain/base/wrapper.py 33.33% <0.00%> (-1.67%) ⬇️
mlchain/cli/mlchain_server.py 0.00% <0.00%> (ø)
mlchain/server/flask_server.py 56.38% <0.00%> (+0.73%) ⬆️
mlchain/server/grpc_server.py 35.08% <0.00%> (ø)
mlchain/server/quart_server.py 26.23% <0.00%> (+0.29%) ⬆️
mlchain/utils/system_info.py 25.00% <25.00%> (ø)
mlchain/server/format.py 50.96% <29.41%> (-2.98%) ⬇️
mlchain/server/view.py 62.58% <50.54%> (+3.08%) ⬆️
mlchain/workflows/parallel.py 67.91% <58.33%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02bfc83...8f3c1e6. Read the comment docs.

@lamhoangtung lamhoangtung merged commit e9e08dd into linus_dev Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lamhoangtung lamhoangtung

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lamhoangtung @meocong