-
Notifications
You must be signed in to change notification settings - Fork 1
📦 Add semantic versioning to all files #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implement per-file semantic versioning (version: X.Y.Z) in frontmatter for skills, commands, agents, rules, and personalities. Versions determined from Git history analysis: - 28 files @ 1.0.0 (production-ready, 2+ months stable) - 7 files @ 0.x (pre-release, actively evolving) - 3 files @ 1.2.0 (marketplace-distributed) - 1 file @ 0.1.0 (brand new, < 2 weeks old) - 2 files @ 2.x (foundational rules with major versions) Update ai-coding-config.md command with version comparison logic for selective updates. Users will be offered updates only when source version > installed version. Consistent versioning criteria: - 0.1.0: Genuinely new (< 2 weeks) - 0.2-0.4: Pre-release with refinements - 1.0.0+: Production-ready or 2+ months with stable history - 2.0+: Major architectural/consolidation changes 🧠 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Move all multi-line descriptions to single-line frontmatter format. Claude requires descriptions on same line as "description:" key - prettier cannot reformat to multiple lines. Descriptions condensed to stay under 88 chars to prevent prettier wrapping: - Commands: generate-AGENTS-file, handoff-context, product-intel, create-prompt, autotask, generate-llms-txt - Personalities: marie-kondo, samantha, sherlock, stewie - Rules: heart-centered-ai-philosophy, trust-and-decision-making, user-facing-language 🧠 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Code ReviewSummaryThis PR implements semantic versioning across 55 files, but has critical gaps that prevent the versioning system from working as intended. 🚨 Critical IssuesMissing version fields in 8 files:
The PR title claims "Add semantic versioning to all files" but 8 files are missing the
|
| --- | ||
| description: Clean up a git worktree after its PR has been merged | ||
| model: haiku | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: New file missing required version field
The newly added cleanup-worktree.md file is missing the version field in its frontmatter, while this PR adds versioning to all 55 other files. The ai-coding-config.md command template explicitly states new artifacts should include version: 1.0.0. Without this field, the version comparison logic treats the file as v0.0.0, causing it to incorrectly participate in the update system being implemented.
Summary
Implement per-file semantic versioning for ai-coding-config using Git history analysis. All 55 files (skills, commands, agents, rules, personalities) now include
version: X.Y.Zin frontmatter.Updated
ai-coding-config.mdcommand with version comparison logic for selective updates.Changes
version: X.Y.Zfields to 55 files based on Git history maturity analysisTesting
✅ Ran prettier - all descriptions remained single-line
✅ All files stay formatted correctly
✅ Claude will parse descriptions correctly
Deployment
[no-deploy]