Add imi Caching test #5860
Merged
Add imi Caching test #5860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NateBrady23
reviewed
Jul 16, 2020
| RUN apt -yqq update > /dev/null && \ | ||
| apt -yqq install git unzip > /dev/null | ||
|
|
||
| WORKDIR /imi | ||
| RUN apt -yqq install redis-server > /dev/null |
There was a problem hiding this comment.
Is there a reason you're installing redis for tests that aren't doing cached queries?
There was a problem hiding this comment.
I have removed non-essential redis
|
@Yurunsoft Can you pull in the latest to get the mysql update that's blocking this? |
|
@nbrady-techempower Thank you very much, it has been fixed |
tomciopp
pushed a commit
to tomciopp/FrameworkBenchmarks
that referenced
this pull request
Oct 21, 2020
* Optimization config * add cached_query_url test * fix init * fix init * fix * fix * Remove non-essential redis * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.