Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable ffead #5815

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

michaelhixson
Copy link
Contributor

The last two runs in the Citrine environment failed because of problems induced by ffead. We don't know that ffead is doing anything wrong -- even if it is, the TFB toolset is to blame for letting that ruin the run -- but we would like to continue benchmarking other frameworks while we figure this out.

The last two runs in the Citrine environment failed because of
problems induced by ffead.  We don't know that ffead is doing
anything wrong -- even if it is, the TFB toolset is to blame for
letting that ruin the run -- but we would like to continue
benchmarking other frameworks while we figure this out.
@NateBrady23
Copy link
Member

@sumeetchhetri just an FYI on this

@NateBrady23 NateBrady23 merged commit 5b544bc into TechEmpower:master Jun 29, 2020
@sumeetchhetri
Copy link
Contributor

@nbrady-techempower, I have been experimenting with a few custom allocators and upgrading a few libraries in the master branch, maybe that caused the issue, will create a new PR with the fixes and the passing verify steps to fix this, in the meanwhile, this should anyways be handled in the tfb toolset for sure to avoid possible future issues with test runs.

@NateBrady23
Copy link
Member

@sumeetchhetri I must have missed this in the review, but your dependencies (including the framework itself) should be a specific commit or version such that breaking changes aren't introduced without going through a PR. Please make sure all your dependencies are locked down as best as possible and I'll review more closely next time.

this should anyways be handled in the tfb toolset for sure to avoid possible future issues with test runs

We understand this: "the TFB toolset is to blame for letting that ruin the run" We're looking into the issue.

@NateBrady23
Copy link
Member

@sumeetchhetri Also, if you happen to know what the offending commit was that you think may have caused this, that would be helpful in tracking down the bug in the the toolset.

tomciopp pushed a commit to tomciopp/FrameworkBenchmarks that referenced this pull request Oct 21, 2020
The last two runs in the Citrine environment failed because of
problems induced by ffead.  We don't know that ffead is doing
anything wrong -- even if it is, the TFB toolset is to blame for
letting that ruin the run -- but we would like to continue
benchmarking other frameworks while we figure this out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants