Fixes a conflict with the Windows file system. #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were you able to test this locally with the changes and get it to run successfully? When running locally on a fork of your branch, I am getting the following error: Is it possible that the aux file is a requirement for fasthttp to run properly? |
|
damn it, I typoed the renamed file location. missed the templates directory. |
|
I don't have a working copy on my machine yet. Had to get the source on it first, which is impossible until this rename is completed. |
|
@KevinBrogan no worries! It looks like it's doing okay on Travis, so as long as it passes on Travis we should be okay to merge this in. |
|
Looks like that fix did the trick. Merging in! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug that makes it impossible to checkout source code on a windows file system.
aux is a reserved keyword