finatra: Patch round-13 code #2210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem There are some improvements we'd like to get into the round-13 testing run. Solution Add the improvements.
|
@cacoco sorry for all of the branching confusion! We're currently using master to represent our preview/final testing for round 13 and round-14 to represent all of the larger tests and features that will be included in our round 14 testing. Would you mind closing this merge request and re-open it against master? |
|
@knewmanTE sure thing. Thanks for the info. Can you tell me when the window will close for patching round 13? Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! There are some improvements we'd like to get into the round-13 testing run for Finatra based on the released preliminary results.
It's not clear if this patch should be done against the current round-13 branch or the round-14 branch. This PR is based on the current round-14 branch. Please let me know if I need to re-do against a different branch to get this into the round-13 testing.