Remove wget #1691
Remove wget #1691
Conversation
| @@ -15,5 +15,5 @@ sed -i 's|/home/vagrant/FrameworkBenchmarks/installs/nginx/|'"${IROOT}"'/nginx/| | |||
|
|
|||
| export PATH="${PHP_HOME}/bin:${PHP_HOME}/sbin:$PATH" | |||
|
|
|||
| hhvm --config $TROOT/deploy/config.hdf --user $(whoami) -m daemon | |||
| hhvm -m daemon --config $TROOT/deploy/config.hdf --user $(whoami) | |||
There was a problem hiding this comment.
Just so we have some explanation on this SOMEWHERE: this was an annoying fix to hhvm simply ignoring input flags because of an incorrect order and STILL starting up but binding to completely different ports as a completely different user.
When -m daemon was at the end, hhvm would bind to 9000 as www-user regardless of the other flags (and this means that the sudo killall -s 9 -u testrunner wouldn't kill it after the tests ran and failed... so other tests couldn't bind to port 9000 and they're report failure too - dropwizard, etc), but moving it to the first argument (hint: not an argument, apparently) fixes this.
SO ANNOYING!!!
There was a problem hiding this comment.
How about a note on the PHP readme about this
|
LGTM! |
wgetwas failing to work on a number of https urls for older-than-ubuntu14 systems because it would attempt to use SSLv3 as the handshake, get turned down, and fail.After attempting a number of options to fix
wget, I fell back on usingcurlinstead. It was just easier.