-
Notifications
You must be signed in to change notification settings - Fork 2k
[rust/water] Remove duplicated tests #10636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
can i have more info about cached-queries cause its 100% worked on my side
|
|
{ |
|
In my local test, also work the cached queries. But not in Citrine servers. EDIT: and remember to add it in the default test. |
|
i need to simulate these servers to see the exact issue VERIFYING CACHED-QUERYFAIL for http://10.0.1.1:8080 |
|
Also have more fails in the bench and tests. https://tfb-status.techempower.com/results/a12d8f43-58bc-4ad1-9277-aa5ab294c10b https://tfb-status.techempower.com/results/acc1ad82-ae2c-4d1d-a600-c7ff9d0c5917 PD: the only difference is the number of CPUs (and workers in the app) using the Citrine servers. As pass the tests in local and in the github actions, than use less CPUs. |
|
Is there full Log that could detect the real issue |
|
Any log will only detect not response. The problem is in the app, and the app need to create the log (not in a file) from what happens. Logs: |
|
So the app is not responding to any request of cached queries and update queries |
|
The first request is with the test, if the test fail for that url, stop the process to run the bench for that url. |
|
Also test it in local, but no the tests only, but the bench. EDIT: |
|
i think its matter of host or port configurations or i dont know cause i tried to increase the workers to 56 and its still working correctly |
|
The problem is in the app, like I said before. More than 800 frameworks permutations work OK with the Citrine servers. |
|
ok i am working on it |
|
In your case is a not response, in other frameworks is a time out problem. It's your app that need to log the problems. Example with perl/kelp showing the problem: |
|
An Http server is a black box, without knowledge of how the server processes them internally. |
|
i finished everything and iam uploading new version my repo but also i could not add cached queries to the default test cause |
|
For me is NOT OK to need another test only for the cached queries. |


All the removed permutations are the same, only with 1 test. The runs need more time without any benefit.
Example with fortunes:

With plaintext:

The cache_query was also removed, as fail in all runs:
https://tfb-status.techempower.com/unzip/results.2026-01-26-17-36-11-536.zip/results/20260118211352/water-http-cached/cached-query/verification.txt
And need to be in the default test, but also fail.
Change Dockerfile, as is not permitted to use latest version.
@HassanSharara