-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix dart3_native regression #10632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix dart3_native regression #10632
Conversation
|
@iapicca Unrelated to this PR, but I'm seeing the following warning on master: |
Hi @p8 Thank you |
|
@iapicca I think you need to delete these: FrameworkBenchmarks/frameworks/Dart/dart3/benchmark_config.json Lines 17 to 18 in a650250
|
|
@p8 done, thank you |
|
Nice! |
Description
This PR partially rolls back changes introduced in #10493.
Motivation
Inter-process port sharing is not supported (see dart-lang/sdk#62545).
As a result, the horizontal “hybrid” scaling approach introduced in the referenced PR does not function correctly.
This causes both performance and image size regressions.
Changes
scratchinstead ofbusyboxFutures andasyncusage)