Update advanced function test #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflaten
force-pushed
the
fflaten-patch-1
branch
from
737df88 to
0e2993a
Compare
fflaten
commented
May 3, 2023
| $CurrentFunction.FullName | Should -FileContentMatch 'cmdletbinding' | ||
| $CurrentFunction.FullName | Should -FileContentMatch 'param' | ||
| It 'Should be an advanced function' -Skip:($Command.CommandType -ne 'Function' -or $Command.Name -in 'grep') -ForEach @{ Command = $Command } { | ||
| $Command.CmdletBinding | Should -BeTrue |
There was a problem hiding this comment.
You could also move the skip-check inside the test and use ex. Set-ItResult -Skipped -Because 'this is a filter' to skip with a clear reason.
By doing it in It '' -Skip:($true), you'll evaluate and skip earlier during Discovery, making it slightly faster at the cost of no skip reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates advanced function test to not use text-based assertion.
Motivation and Context
https://twitter.com/techdufus/status/1649075789822918656?s=20 hurts my eyes. 😄
Types of changes
Checklist