Skip to content

Close #8 In material-ui 0.19.0 onTouchTap has been removed. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leMaik merged 5 commits into from
Sep 1, 2017
Merged

Close #8 In material-ui 0.19.0 onTouchTap has been removed. #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60c489c
Replace onTouchTap with onClick
Aug 28, 2017
3b85683
Update material-ui to 0.19.0 in devDependencies and peerDependencies
Aug 28, 2017
e1f81e6
Uninstall react-tap-event-plugin
Aug 28, 2017
c233bb1
Remove react-tap-event-plugin from peerDependencies
Aug 28, 2017
a358c71
0.6.0
Aug 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import FullscreenDialog from 'material-ui-fullscreen-dialog'
title={'Demo dialog'}
actionButton={<FlatButton
label='Done'
onTouchTap={() => this.setState({ open: false })}
onClick={() => this.setState({ open: false })}
/>}
>
// dialog content here
Expand Down
8 changes: 1 addition & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "material-ui-fullscreen-dialog",
"version": "0.5.0",
"version": "0.6.0",
"description": "A fullscreen dialog for Material-UI.",
"main": "lib/FullscreenDialog.js",
"scripts": {
Expand Down Expand Up @@ -36,18 +36,16 @@
"babel-preset-es2015": "^6.14.0",
"babel-preset-react": "^6.11.1",
"babel-preset-stage-0": "^6.5.0",
"material-ui": "^0.17.4",
"material-ui": "^0.19.0",
"react": "^15.5.4",
"react-dom": "^15.5.4",
"react-tap-event-plugin": "^2.0.1",
"react-transition-group": "^1.1.1",
"standard": "^10.0.2"
},
"peerDependencies": {
"material-ui": ">=0.17.0 <1.0.0",
"material-ui": ">=0.19.0 <1.0.0",
"react": "^15.5.4",
"react-dom": "^15.5.4",
"react-tap-event-plugin": "^2.0.1",
"react-transition-group": "^1.1.1"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion src/FullscreenDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default function FullscreenDialog (props, { muiTheme }) {
titleStyle={titleStyle}
style={{ ...styles.appBar, ...appBarStyle }}
iconElementLeft={(
<IconButton onTouchTap={onRequestClose}>
<IconButton onClick={onRequestClose}>
{closeIcon || <NavigationCloseIcon />}
</IconButton>
)}
Expand Down
4 changes: 2 additions & 2 deletions stories/FullscreenDialogDemo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default class extends React.Component {
title='Some demo dialog'
actionButton={<FlatButton
label='Done'
onTouchTap={() => this.setState({ open: false })}
onClick={() => this.setState({ open: false })}
/>}
>
<TextField
Expand All @@ -38,7 +38,7 @@ export default class extends React.Component {
</FullscreenDialog>

<RaisedButton
onTouchTap={() => this.setState({ open: true })}
onClick={() => this.setState({ open: true })}
label='Open dialog'
/>
</div>
Expand Down