Switch from Prow's values to those for Perspective #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment about Linux: colored pushbuttons don't seem to show on Pi OS, which I think is based on LXDE? Need to verify on other DEs (Xf, GNOME maybe). It does appear fine on Windows: and KDE Plasma: |
Forgot to make the program wait for reading. Easy mistake to make. =w=;
Just to be foolproof, give it three goes before calling the patient dead.
(only when the board original value is no custom pins)
(And placeholders for NeoPixel color stuff soon shhhhh)
Pings the board every 5 seconds with a throwaway command; if write succeeds, all's good, but failure assumes that the board must have disconnected or is otherwise unavailable, so set the port off to avoid user confusion.
Disabled buttons are now shown as disabled upon load/save. Temperature sensor and analog stick are now shown in test tab. Temp sensor will update temperature when temp update is received, and the color will reflect that (green for good, orange for warning, red for danger). Analog stick will update with loose relative position when it receives an analog update, represented by an arrow unicode glyph.
The defaults load wasn't loading because it was in the switch-case but not actually in a case... GUH
Sorry Waveshare, it's not you it's me </3
Pixel Static settings is now properly exposed to the user with a similar paradigm to the selectable profile colors in the profiles tab. LED tests were a requested thing during the whole Pixel troubleshooting debacle. Simple TUSB identifier presets should have a certain someone chill the fuck out at least.
|
Similarly to the firmware PR, this has become something of a megacommit so we need not wait any longer. Firmware has been updated, so we'll do the same here. Everything in the app so far lgtm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title, pretty much. Since perspective has a couple more values for profiles that needs to be imported.
That said, I don't actually know if we need to show necessarily ALL the values?
For anyone who wants to try the current state of the branch:
OpenFIREapp-win64.zip (Windows 7+)
June 5th EDIT: The OpenFIRE Vendor ID has been shifted from 0x0920 to 0xF143 now, so make sure both your firmware and app are updated!!!