Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PeerTube] Support searching for playlists and channels #996

Merged
merged 3 commits into from
Jan 2, 2023
Merged

[PeerTube] Support searching for playlists and channels #996

merged 3 commits into from
Jan 2, 2023

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Dec 4, 2022

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@TobiGr TobiGr added enhancement peertube service, https://joinpeertube.org/ labels Dec 4, 2022
@TobiGr TobiGr changed the title [PeerTube] Support searching for playlists [PeerTube] Support searching for playlists and channels Dec 4, 2022
Stypox
Stypox requested changes Dec 31, 2022
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good to me, thanks :-)

...ctor/src/main/java/org/schabi/newpipe/extractor/services/peertube/PeertubeParsingHelper.java Outdated Show resolved Hide resolved
.../schabi/newpipe/extractor/services/peertube/extractors/PeertubeChannelInfoItemExtractor.java Show resolved Hide resolved
.../schabi/newpipe/extractor/services/peertube/extractors/PeertubeChannelInfoItemExtractor.java Outdated Show resolved Hide resolved
Stypox
Stypox approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The CI fail is unrelated

@Stypox Stypox merged commit ce15f7c into dev Jan 2, 2023
@opusforlife2 opusforlife2 deleted the feat/peeertube-playlists branch January 2, 2023 14:10
@AudricV AudricV mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
enhancement peertube service, https://joinpeertube.org/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiGr @Stypox