Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Description object for comments text. #987

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Use Description object for comments text. #987

merged 1 commit into from
Nov 29, 2022

Conversation

FireMasterK
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

See #928 (comment)

@AudricV AudricV added enhancement multiservice Issues related to multiple services labels Nov 28, 2022
TobiGr
TobiGr approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Stypox
Stypox requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java Outdated Show resolved Hide resolved
...schabi/newpipe/extractor/services/peertube/extractors/PeertubeCommentsInfoItemExtractor.java Show resolved Hide resolved
...g/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java Outdated Show resolved Hide resolved
@TobiGr TobiGr merged commit 72d5ed3 into TeamNewPipe:dev Nov 29, 2022
@FireMasterK FireMasterK deleted the comments-text-description branch November 29, 2022 15:59
@FireMasterK FireMasterK mentioned this pull request Nov 29, 2022
Merged
3 tasks
@Stypox Stypox mentioned this pull request Jan 15, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
enhancement multiservice Issues related to multiple services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FireMasterK @TobiGr @Stypox @AudricV