Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerTube short links support #743

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Nov 3, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

ASAP because it's the default path for instances with version 3.3.0 and above.

fixes #678

related NewPipe PR: TeamNewPipe/NewPipe#7353

@B0pol B0pol changed the title Peertube shortlinks support PeerTube short links support Nov 3, 2021
@B0pol B0pol added bug Issue is related to a bug peertube service, https://joinpeertube.org/ ASAP Issue needs to be fixed as soon as possible labels Nov 3, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Code looks fine:

  • comments and doc is present
  • new/improved tests

Test are working as expected.

@litetex litetex merged commit 7e7b78f into TeamNewPipe:dev Nov 4, 2021
@B0pol B0pol deleted the peertube-shortlinks branch November 4, 2021 15:36
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug peertube service, https://joinpeertube.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for short PeerTube URLs
2 participants