-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Uploader's Avatar on YouTube and PeerTube #723
Conversation
0281832
to
00c8f2e
Compare
Thank you @FireMasterK! Could you add some description? Does this add support for channel avatars of stream info items? |
00c8f2e
to
b9fad4f
Compare
Done! It indeed does, this currently only works in the Search and Trending pages I believe as YouTube doesn't provide these anywhere else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost good to me :-)
...st/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorTest.java
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java
Outdated
Show resolved
Hide resolved
...st/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorTest.java
Outdated
Show resolved
Hide resolved
...org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can also be tested roughly in DefaultTests.defaultTestListOfItems()
.
Please remove throws ParsingException
when overriding the method and returning null
...g/schabi/newpipe/extractor/services/peertube/extractors/PeertubeStreamInfoItemExtractor.java
Show resolved
Hide resolved
abe4ef5
to
c4f32dd
Compare
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
c4f32dd
to
db6b3b2
Compare
What about services which in which it's not extracted in? Another thing to note is that even on YouTube, it's not provided everywhere. |
Testing this should be similar to testing the thumbnail URL final String uploaderAvatarUrl = item.getUploaderAvatarUrl();
if (!isNullOrEmpty(uploaderAvatarUrl)) {
assertIsSecureUrl(uploaderAvatarUrl);
} |
Added, thanks for the clarification on what you meant! |
This pull request adds support for Channel Avatars extraction in the
StreamInfoItem
class.