Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YouTube music search. #699

Merged
merged 4 commits into from
Aug 1, 2021
Merged

Conversation

FireMasterK
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Closes #698

I've only tested this with the help of the tests.

@Stypox
Copy link
Member

Stypox commented Jul 31, 2021

The CI seems to fail, in part due to music search issues. Maybe you should update the mocks?

@FireMasterK
Copy link
Member Author

Something odd is going on, the tests were passing locally, so might be something related to different regions. I've used an EU IP and fixed it now.

Mocks are disabled for this test:

// Doesn't work with mocks. Makes request with different `dataToSend` i think

@AudricV AudricV added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Jul 31, 2021
@Stypox Stypox merged commit 06a5219 into TeamNewPipe:dev Aug 1, 2021
@FireMasterK FireMasterK deleted the yt-music-search branch August 1, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Youtube has changed the json format of results so YoutubeMusicSearchExtractor is no longer returning items
3 participants