-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand regex to match n param decrypt function #696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangRongLin
added
bug
Issue is related to a bug
youtube
service, https://www.youtube.com/
labels
Jul 29, 2021
@Stypox I took the liberty to add your solution here directly |
Stypox
requested changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks good to me
extractor/src/main/java/org/schabi/newpipe/extractor/utils/Parser.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/utils/StringUtil.java
Outdated
Show resolved
Hide resolved
.../test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingDecrypterTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingDecrypterTest.java
Outdated
Show resolved
Hide resolved
AudricV
previously requested changes
Jul 29, 2021
extractor/src/main/java/org/schabi/newpipe/extractor/utils/StringUtil.java
Outdated
Show resolved
Hide resolved
Stypox
reviewed
Jul 29, 2021
extractor/src/main/java/org/schabi/newpipe/extractor/utils/StringUtils.java
Show resolved
Hide resolved
Stypox
requested changes
Jul 31, 2021
extractor/src/main/java/org/schabi/newpipe/extractor/utils/StringUtils.java
Outdated
Show resolved
Hide resolved
Stypox
approved these changes
Aug 1, 2021
5 tasks
Hmmm how can I get the .apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary solution by expanding the regex, which extracts the decrypt function.
Depending on how long/difficult a proper solutions turns out, this could be unneeded. @Stypox