[YouTube] Fix buffering by decoding n parameter of stream urls #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done by transforming the parameter "n" from videoplayback urls ytdl-org/youtube-dl#29326 (comment)
XiangRongLin
added
bug
This was referenced Jul 15, 2021
Previously it replaced the parameter itself not the value of the parameter.
|
I cleaned up the code and added some tests for it. Now it's just waiting to see if the problem still occurs with this change. |
|
Seeing how the before-clean-up version seems to be working fine for a few days now, I would mark this as ready for review, so we can get this issue fixed |
TobiGr
reviewed
Jul 20, 2021
.../src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeJavascriptExtractor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeJavascriptExtractor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeJavascriptExtractor.java
Outdated
Show resolved
Hide resolved
.../test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeJavascriptExtractorTest.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/utils/Javascript.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
Also address review and rewrite some comments
…me nParam multiple times. Closes TeamNewPipe#689
litetex
reviewed
Jul 26, 2021
.../src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeJavaScriptExtractor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeJavaScriptExtractor.java
Show resolved
Hide resolved
.../src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingDecrypter.java
Show resolved
Hide resolved
Use final where possible, annotate some methods and parameters as Nonnull and format new code to be in the 100 characters limit per line.
…lyStreams methods of YoutubeStreamExtractor Without this commit, the n param is only decrypted for streams extracted in getVideoStreams (so only for streams in the formats object of the player response).
TobiGr
reviewed
Jul 28, 2021
.../test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingDecrypterTest.java
Outdated
Show resolved
Hide resolved
TobiGr
approved these changes
Jul 28, 2021
|
There are still failing tests, but they are not related to this PR. |
TobiGr
added a commit
that referenced
this pull request
Jul 28, 2021
[YouTube] Fix buffering by decoding n parameter of stream urls
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.No compatibility changesMy attempt at fixing TeamNewPipe/NewPipe#6510 by applying the javascript function to decode n parameter as mentioned here TeamNewPipe/NewPipe#6510 (comment)
I think this implementation is correct, but I could not confirm it because just these changes are not enough to solve the problem. NewPipe itself needs to also apply the decoder on the urls while streaming.
Code is ugly, because I don't 100% know if it is working and did not want to put more time into it