Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PeerTube] Support livestreams #661

Merged
merged 1 commit into from
Jul 13, 2021
Merged

[PeerTube] Support livestreams #661

merged 1 commit into from
Jul 13, 2021

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Jun 18, 2021 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
    not needed

I'm using a workaround but it works in NewPipe

fixes #473

@TobiGr TobiGr added enhancement peertube service, https://joinpeertube.org/ labels Jun 18, 2021
@Stypox
Copy link
Member

Stypox commented Jun 24, 2021

@B0pol could you provide an APK and (if possible) a livestream link?

@B0pol
Copy link
Member Author

B0pol commented Jun 24, 2021

Livestreams: you can find some there https://video.ploud.fr/search?isLive=true as I told in #473

APK: app-debug.zip

Stypox
Stypox approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@B0pol I can confirm it works, thank you :-)
Code also looks good.

@B0pol B0pol merged commit c38a06e into TeamNewPipe:dev Jul 13, 2021
@Stypox Stypox mentioned this pull request Aug 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
enhancement peertube service, https://joinpeertube.org/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PeerTube livestreams
3 participants
@B0pol @Stypox @TobiGr