Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Identifiers #1205

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Refactored Identifiers #1205

merged 1 commit into from
Nov 13, 2024
+17 −17

Conversation

congyuluo
Copy link
Contributor

@congyuluo congyuluo commented Jul 30, 2024 •
edited by TobiGr
Loading

Refactored several identifiers in the code for better coherence to the variable/identifier's usage in the code.

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Important

Breaking changes

Stream.equalStats(Stream) is renamed to Stream.areStatsEqual(Stream)
Stream.getBitrate() is renamed to Stream.getBitRate()

@TobiGr TobiGr added the codequality Improvements to the codebase to improve the code quality label Nov 13, 2024
TobiGr
TobiGr approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@TobiGr TobiGr merged commit 0de2241 into TeamNewPipe:dev Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@congyuluo @TobiGr