Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeerTube] Fix multi level comment replies #1052

Merged
merged 2 commits into from
May 18, 2023

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Apr 16, 2023

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API. (not needed)

Nested replies are stored in the original thread response and are now stored inside the Page's body returned by getReplies().

Test with this video https://share.tube/w/vxu4uTstUBAUromWwXGHrq .

@TobiGr TobiGr added bug Issue is related to a bug peertube service, https://joinpeertube.org/ labels Apr 16, 2023
@TobiGr TobiGr force-pushed the peertube/fix/nested-comment-replies branch from 0c5bb0a to 3780f05 Compare April 16, 2023 21:38
Stypox
Stypox previously requested changes Apr 20, 2023
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I tested and it works. Just one small thing to fix :-)

@TobiGr TobiGr force-pushed the peertube/fix/nested-comment-replies branch from 3780f05 to f7118b8 Compare April 20, 2023 18:00
@TobiGr TobiGr force-pushed the peertube/fix/nested-comment-replies branch from f7118b8 to d358ba1 Compare May 7, 2023 20:56
@AudricV AudricV dismissed Stypox’s stale review May 18, 2023 16:48

Outdated review

@AudricV AudricV merged commit 92a0024 into dev May 18, 2023
@AudricV AudricV deleted the peertube/fix/nested-comment-replies branch May 18, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug peertube service, https://joinpeertube.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants