Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 0.24.1 (991) #9286

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Add changelog for 0.24.1 (991) #9286

merged 1 commit into from
Nov 3, 2022

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Nov 3, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added the meta Related to the project but not strictly to code label Nov 3, 2022
@TobiGr TobiGr merged commit e9870d9 into dev Nov 3, 2022
@opusforlife2 opusforlife2 deleted the changelog/0.24.1 branch November 3, 2022 19:02
@ghost
Copy link

ghost commented Nov 4, 2022

The APK can be found by going to the "Checks" tab below the title.

There is no APK.

@opusforlife2
Copy link
Collaborator

There is nothing to test here. Why do you want the APK, @Symbian9?

@ghost
Copy link

ghost commented Nov 4, 2022

Why do you want the APK

To test latest dev-branch builds. There no any automatic built APKs (artifacts) provided by CI (is it common issue to GitHub Actions in NewPipe repo?)

N.B. I see that there is just manually uploaded APK in #9290, but its not automatic CI built artifact.

Many pull requests has next note in description:

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

But it seems like there are no CI-built APKs (artifacts) on the "Checks" tab in any of such pulls.

@opusforlife2
Copy link
Collaborator

It's there in most of them. This PR just didn't change any app code at all, so the APK wasn't created. Look for the RC issue if you want to test.

@opusforlife2
Copy link
Collaborator

I went to PR 9290 and the APK is exactly where the "APK testing" section describes. Are you opening that page while signed in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants