Add an Open in browser button on error panel

app/src/main/java/org/schabi/newpipe/error/ErrorInfo.kt

@@ -82,10 +82,8 @@ class ErrorInfo(
 
         fun throwableListToStringList(throwableList: List<Throwable>) =
             throwableList.map { it.stackTraceToString() }.toTypedArray()
-
         private fun getInfoServiceName(info: Info?) =
             if (info == null) SERVICE_NONE else ServiceHelper.getNameOfServiceById(info.serviceId)
-
         @StringRes
         private fun getMessageStringId(
             throwable: Throwable?,

app/src/main/java/org/schabi/newpipe/error/ErrorPanelHelper.kt

@@ -2,12 +2,14 @@ package org.schabi.newpipe.error
 
 import android.content.Context
 import android.content.Intent
+import android.net.Uri
 import android.util.Log
 import android.view.View
 import android.widget.Button
 import android.widget.TextView
 import androidx.annotation.Nullable
 import androidx.annotation.StringRes
+import androidx.core.content.ContextCompat.startActivity
 import androidx.core.view.isVisible
 import androidx.fragment.app.Fragment
 import com.jakewharton.rxbinding4.view.clicks
@@ -52,6 +54,8 @@ class ErrorPanelHelper(
         errorPanelRoot.findViewById(R.id.error_action_button)
     private val errorRetryButton: Button =
         errorPanelRoot.findViewById(R.id.error_retry_button)
+    private val errorOpenbrowserButton: Button =
+        errorPanelRoot.findViewById(R.id.error_openinbrowser)
 
     private var errorDisposable: Disposable? = null
 
@@ -69,19 +73,17 @@ class ErrorPanelHelper(
         errorServiceExplanationTextView.isVisible = false
         errorActionButton.isVisible = false
         errorRetryButton.isVisible = false
+        errorOpenbrowserButton.isVisible = false
     }
 
     fun showError(errorInfo: ErrorInfo) {
-
         if (errorInfo.throwable != null && errorInfo.throwable!!.isInterruptedCaused) {
             if (DEBUG) {
                 Log.w(TAG, "onError() isInterruptedCaused! = [$errorInfo.throwable]")
             }
             return
         }
 
-        ensureDefaultVisibility()
-
         if (errorInfo.throwable is ReCaptchaException) {
             errorTextView.setText(R.string.recaptcha_request_toast)
 
@@ -99,6 +101,7 @@ class ErrorPanelHelper(
             }
 
             errorRetryButton.isVisible = true
+            errorOpenbrowserButton.isVisible = true
         } else if (errorInfo.throwable is AccountTerminatedException) {
             errorTextView.setText(R.string.account_terminated)
 
@@ -127,6 +130,12 @@ class ErrorPanelHelper(
             ) {
                 // show retry button only for content which is not unavailable or unsupported
                 errorRetryButton.isVisible = true
+                errorOpenbrowserButton.isVisible = true
+                errorOpenbrowserButton.setOnClickListener {
+                    val uriUrl = Uri.parse(errorInfo.request)
+                    val intent = Intent(Intent.ACTION_VIEW, uriUrl)
+                    context.startActivity(intent)
+                }
             }
         }
 

app/src/main/res/layout/error_panel.xml

@@ -72,4 +72,19 @@
         android:visibility="gone"
         tools:visibility="visible" />
 
+    <Button
+        android:id="@+id/error_openinbrowser"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="4dp"
+        android:layout_marginBottom="8dp"
+        android:text="@string/error_openinbrowser"
+        android:textAlignment="center"
+        android:textAllCaps="true"
+        android:textAppearance="@style/TextAppearance.AppCompat.Body1"
+        android:textSize="16sp"
+        android:theme="@style/ServiceColoredButton"
+        android:visibility="gone"
+        tools:visibility="visible" />
+
 </LinearLayout>

app/src/main/res/values/strings.xml

@@ -251,6 +251,7 @@
     <string name="error_report_open_github_notice">Please check whether an issue discussing your crash already exists. When creating duplicate tickets, you take time from us which we could spend with fixing the actual bug.</string>
     <string name="error_snackbar_message">Sorry, something went wrong.</string>
     <string name="error_snackbar_action">Report</string>
+    <string name="error_openinbrowser">Open in Browser</string>
     <string name="what_device_headline">Info:</string>
     <string name="what_happened_headline">What happened:</string>
     <string name="info_labels">What:\\nRequest:\\nContent Language:\\nContent Country:\\nApp Language:\\nService:\\nGMT Time:\\nPackage:\\nVersion:\\nOS version:</string>