Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide play queue button in VideoDetailsFragment when queue is empty #9109

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Oct 11, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Hide the play queue button in the mini player in the VideoDetailsFragment when the play queue is empty.
Related PR introducing the button: #8946

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

…lay queue is empty

Related PR introducing the button: #8946
@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Oct 11, 2022
@TobiGr TobiGr requested a review from Stypox October 11, 2022 19:29
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ShareASmile
Copy link
Collaborator

@Stypox gentle reminder to review this PR , I tested & found no problems with it, expect Team devs won't ship 0.24.1 without it.

I woluld like to mention this in release candidate #9292

@Stypox Stypox changed the base branch from dev to release/0.24.1 November 5, 2022 19:28
@Stypox Stypox merged commit 9472c36 into release/0.24.1 Nov 5, 2022
@opusforlife2 opusforlife2 deleted the fix/overlayPlayQueueButton branch November 5, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants