-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create media session UI and fix player notification #8678
Commits on Aug 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c054ea0 - Browse repository at this point
Copy the full SHA c054ea0View commit details -
Remove useless MediaSessionCallback
The player is now passed directly, it made no sense to wrap around it in a callback that was not really a callback but rather, actually, a wrapper.
Configuration menu - View commit details
-
Copy full SHA for bc33322 - Browse repository at this point
Copy the full SHA bc33322View commit details -
Fix thumbnail sometimes not set to media session metadata
The thumbnail was not being updated in the media session metadata after it was loaded, since there was no metadata update in that case, only a notification update.
Configuration menu - View commit details
-
Copy full SHA for 3cc43e9 - Browse repository at this point
Copy the full SHA 3cc43e9View commit details -
Fix sometimes seeing outdated thumbnail in notification
Before the thumbnail finishes loading for the new video the player is now playing, the old thumbnail was being used, leading to wrong thumbnails set in the media session and the notification.
Configuration menu - View commit details
-
Copy full SHA for f3a9b81 - Browse repository at this point
Copy the full SHA f3a9b81View commit details -
Even when thumbnails should not be shown, set it to null in notification
This makes sure the thumbnail is removed from the notification if the user disables thumbnails
Configuration menu - View commit details
-
Copy full SHA for d73ca41 - Browse repository at this point
Copy the full SHA d73ca41View commit details -
Remove useless checks before updating metadata
A while ago NewPipe called the metadata update function very often, so checks were needed to ensure not wasting time updating metadata if it were already up to date. Now, instead, the metadata update function is called exactly when needed, i.e. when metadata changes, so such checks are not needed anymore (and were probably also a little resource-heavy).
Configuration menu - View commit details
-
Copy full SHA for 8bff445 - Browse repository at this point
Copy the full SHA 8bff445View commit details -
Let exoplayer decide when to update metadata
Though still make sure metadata is updated after the thumbnail is loaded. This fixes the wrong seekbar properties (duration and current position) being shown in the notification sometimes.
Configuration menu - View commit details
-
Copy full SHA for f80d1dc - Browse repository at this point
Copy the full SHA f80d1dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11bd236 - Browse repository at this point
Copy the full SHA 11bd236View commit details -
Keep strong reference to Picasso thumbnail loading target
Before the Target would sometimes be garbage collected before being called with the loaded thumbnail, since Picasso holds weak references to targets
Configuration menu - View commit details
-
Copy full SHA for 510efaa - Browse repository at this point
Copy the full SHA 510efaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 973a966 - Browse repository at this point
Copy the full SHA 973a966View commit details -
+ Automatically fixed code style (imports)
Configuration menu - View commit details
-
Copy full SHA for 59d1ded - Browse repository at this point
Copy the full SHA 59d1dedView commit details