Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert part of #6872 and fix playback resuming #7286

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Oct 20, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR fixes playback resuming by readding the related parameter in the getPlayerIntent function. I checked all places where getPlayerIntent was used and the behaviour should now be the same as pre-#6872, except for a small part: when enqueueing resumePlayback is always false. @TobiGr @Redirion

In #6872 (review) I said that resumePlayback should be set to true when the play buttons are pressed in the channel and playlist fragments; this shall not be done here as this is a hotfix PR.

Fixes the following issue(s)

APK testing

I tested and everything seems to be back to normal. The CI for some reason didn't run for this PR, so here is a manually built apk: app-debug.zip

Due diligence

Fun fact: this PR's digits, i.e. 7286, are a permutation of the broken PR's, i.e. 6872

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works good 👍


Fun fact: this PR's digits, i.e. 7286, are a permutation of the broken PR's, i.e. 6872

As a math student, I love this ❤️ Nice catch (Unfortunately, the issue in which the problem is tracked, is a little of: 7236)

@TobiGr TobiGr merged commit ac071b3 into release/0.21.13 Oct 20, 2021
@TobiGr TobiGr deleted the fix-resume branch October 20, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants