Revert part of #6872 and fix playback resuming #7286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR fixes playback resuming by readding the related parameter in the
getPlayerIntent
function. I checked all places wheregetPlayerIntent
was used and the behaviour should now be the same as pre-#6872, except for a small part: when enqueueingresumePlayback
is alwaysfalse
. @TobiGr @RedirionIn #6872 (review) I said that
resumePlayback
should be set totrue
when the play buttons are pressed in the channel and playlist fragments; this shall not be done here as this is a hotfix PR.Fixes the following issue(s)
APK testing
I tested and everything seems to be back to normal. The CI for some reason didn't run for this PR, so here is a manually built apk: app-debug.zip
Due diligence
Fun fact: this PR's digits, i.e. 7286, are a permutation of the broken PR's, i.e. 6872