-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check for new Version and release 0.21.12 #7232
Conversation
edbff6c
to
2981c81
Compare
When the service is started from the Application class, the app might be still in the background. This is definetly not the case when MainActivity.onCreate() is called. Fixes #7227
2981c81
to
7c9896b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and already tested in linked issue
I got this one again: the phone had battery save mode enabled. Exception
Crash log
|
I think we need to put this into
|
This would be executed many times then though |
I tried to circumvent this. See #7268 |
What is it?
Description of the changes in your PR
The service for checking for a new NewPipe version was started too early when the app was still in background sometimes.
Starting the service is now moved from
App.onCreate()
toMainActivity.onCreate()
.Fixes the following issue(s)
Fixes #7227
APK testing
Testing this with debug applications does not work. Take the APK from #7227 (comment)
Due diligence