Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update READMEs #7184

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Update READMEs #7184

merged 1 commit into from
Oct 2, 2021

Conversation

ygz213
Copy link
Contributor

@ygz213 ygz213 commented Sep 30, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Change "Github" word as "GitHub" (all README files)
  • Change translation of "Screenshots" with its more common translation (README.tr.md)

Fixes the following issue(s)

  • Some typos and bad translations

Due diligence

@ygz213
Update READMEs
10846b3 
* Change "Github" as "GitHub"
* Change translation of "Screenshots" with its more common translation (README.tr.md)
@AudricV AudricV added localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code labels Sep 30, 2021
triallax
triallax approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@triallax triallax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; will merge in a couple days if no other team member has anything to say.

@TobiGr TobiGr merged commit f165f97 into TeamNewPipe:dev Oct 2, 2021
This was referenced Oct 2, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triallax triallax triallax approved these changes

Assignees
No one assigned
Labels
localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ygz213 @triallax @TobiGr @AudricV