Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Groupie library to 2.9.0 #7150

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Do we have any update calls that could reasonably be replaced with replaceAll? I checked them all, but I'm asking just in case. Here is context.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TacoTheDank TacoTheDank mentioned this pull request Sep 23, 2021
5 tasks
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also lgtm

However after this I have to rebase #7050 😭

@litetex litetex merged commit 672eb34 into TeamNewPipe:dev Sep 30, 2021
@TacoTheDank
Copy link
Member Author

However after this I have to rebase #7050 😭

Oof, sorry :P

@TacoTheDank TacoTheDank deleted the groupieBump branch September 30, 2021 19:37
This was referenced Oct 2, 2021
@TacoTheDank TacoTheDank added the codequality Improvements to the codebase to improve the code quality label Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants