Simple Codebase Improvement #7132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
Sep 21, 2021
app/src/androidTest/java/org/schabi/newpipe/local/playlist/LocalPlaylistManagerTest.kt
Outdated
Show resolved
Hide resolved
triallax
previously approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Looks good to me, but a couple things:
- please use more descriptive commit messages. I know that the message you used is the one provided by GitHub by default, but you can change it.
- please don't remove the template that was there next time you open a PR (or issue for that matter).
Thanks!
|
Does this error is by that modification ? |
Stypox
approved these changes
Sep 21, 2021
triallax
approved these changes
Sep 21, 2021
What do you mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: it was added a string variable to avoid replication one.