Fix handling exception in playOnPopup and toggle description tab
#7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litetex
reviewed
Sep 4, 2021
|
You can follow the steps provided in our Matrix channel.
Only found one, I guess the others were closed as duplicates. The other |
…minimized player in VideoDetailFragment The comments tab was updated although the settings for the description tab were changed.
TobiGr
force-pushed
the
fix/playOnPopup
branch
from
81d1419
to
ce8c2bf
Compare
|
Fixed the |
litetex
reviewed
Sep 5, 2021
app/src/main/java/org/schabi/newpipe/util/external_communication/InternalUrlsHandler.java
Outdated
Show resolved
Hide resolved
|
Test looks good, works like a charm :) |
…server() Hopefully also fix the cause of the original error.
TobiGr
force-pushed
the
fix/playOnPopup
branch
from
ce8c2bf
to
4d51ebc
Compare
Stypox
approved these changes
Sep 10, 2021
Closed
|
Why didn't it close the issues linked to it? |
|
No idea. Anyway, that issue is still not solved, apparently, so it needs to stay open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
OnErrorNotImplementedExceptioninInternalUrlsHandler.playOnPopupby implementing error handling. A popup is shown with a little info on the error:OnErrorNotImplementedExceptioninSearchFragment.initSuggestionObserver(). Errors are reported in the snackbar now. Not sure if I also managed to fix the cause of the original error. This needs to be investigated.Fixes issues
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence