-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all buttons in player have selectable item background borderless #7042
Conversation
Before/after screenshot, pls. |
I think we should keep the rectangular background for ratio, subtitles and quality selector commands. |
Except buttons with long text or text that changes on click
96d94c8
to
0712aa0
Compare
I would have to upload something like twenty screenshots, one for each button, so I don't think it would be much useful in this case.
I did this @TiA4f8R @litetex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm personally okay with the changes 😄
Just one example would be enough, I think? It's only needed to get an idea of what the change looks like. I can't figure that out from your description. |
Thanks, @Stypox. After seeing the screenshot, I agree with TiA4f8R. The icons certainly look better with a circular background, but text menus should still have a rectangular one.
|
Ok, that's done (only the speed selector still has a circular background), thanks for the feedback ;-) |
(just tested on API 19 emulated and it works) |
What is it?
Description of the changes in your PR
I replaced all
selectableItemBackground
s in the player withselectableItemBackgroundBorderless
, so that the press animation looks better. I also did this to text buttons (fit-fill-zoom, captions, resolution, time), and I think it is better than non-borderless even though there are some small issues: the text changing when tapping fit-fill-zoom and when opening the resolution menu (MPEG-4 is added to the string) causes some artifacts in the animation, and the captions button, since it contains a long text, causes a big circle. Please provide your feedback :-)I also ran
CTRL+ALT+L
to auto format and fixed some RTL warnings.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence