Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed double tapping the replay button #7014

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

litetex
Copy link
Member

@litetex litetex commented Aug 29, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Simpler successor to #6322.
Fixes double tapping the replay button

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Aug 29, 2021
@opusforlife2
Copy link
Collaborator

Ah. Yes. Please merge this soon. Quite an annoying bug. When was it introduced? I think it was in the 0.21.x series.

@tsiflimagas
Copy link
Contributor

It works great, thank you for this!

@litetex
Copy link
Member Author

litetex commented Aug 29, 2021

@opusforlife2
Maybe we should add the ASAP label?
I think it must have happened somewhere in <=0.21.2

You can also review/test it and give it a ✔️ then it may be even faster merged 😄

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@TobiGr TobiGr merged commit 46f74b9 into TeamNewPipe:dev Aug 29, 2021
@opusforlife2
Copy link
Collaborator

You can also review/test it and give it a ✔️ then it may be even faster merged 😄

I'm not supposed to do that, since I'm not a dev. 👀

@litetex
Copy link
Member Author

litetex commented Aug 29, 2021

@opusforlife2
Whoops I didn't know that 😆

@litetex litetex deleted the fix-double-tapping-replay-button branch August 29, 2021 17:12
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replaying a video in any player requires tapping the replay button twice
4 participants