-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build problems and updated kotlin #6986
Fix build problems and updated kotlin #6986
Conversation
app/src/main/java/org/schabi/newpipe/local/feed/service/FeedLoadService.kt
Outdated
Show resolved
Hide resolved
I got this when refreshing the feed Exception
Crash log
|
You are correct. When you refresh the feed and there is no "Feed update threshold" active it fails. I'll revert the affected commit then 😄 |
I think it's a bug / change with the kotlin plugin for android studio. When I was using the 1.5.21 versions on your PR it had a type hint of |
273249b
to
b061423
Compare
There seems to be a bug in the kotlin plugin as it tells you when building that this can't be null: "Condition 'throwable != null' is always 'true'" However it can indeed be null as seen in TeamNewPipe#6986 (comment)
Should be ready for review again 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
What is it?
Description of the changes in your PR
kotlin-parcelize
References:
experimental = true
as it doesn't work anymore in Android Studio and without it the app works fine (subscription groups, feed, etc)kotlinx.android.parcel
withkotlinx.parcelize
Fixed "conditionthrowable != null
is alwaystrue
"APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence