Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set KeyProgressIncrement manually / Fix long seekbar jumps when using a DPad #6985

Conversation

litetex
Copy link
Member

@litetex litetex commented Aug 26, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Set KeyProgressIncrement manually to the value of the seek duration in the settings so that it works when using the DPad
  • consolidated code inside a new method to avoid duplication

Before/After Screenshots/Screen Record

NewPipeKeyProgressIncrementManuallyDPadFixDemo1.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

* Set ``KeyProgressIncrement`` manually to the value of the seek duration in the settings so that it works when using the DPad
* consolidated code inside a new method to avoid duplication
@litetex
Copy link
Member Author

litetex commented Aug 26, 2021

If anyone has better ideas to which region the setVideoDurationToControls-method should be added: Those are welcome 😄
I had no idea where to put it so I ended up using the Playback position and seek-region.

@AudricV AudricV added Android TV Issue is related to Android TV feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Aug 26, 2021
@TobiGr
Copy link
Member

TobiGr commented Aug 26, 2021

@0metz0 Please test the APK from the CI on your TV and tell us whether the issue is fixed.

@ghost
Copy link

ghost commented Aug 27, 2021

Hi this works as intended on Android TVs using the dpad, thanks litetex.
TV remote specific buttons (like fastforward/backward) don't work as intended as the "Player seekbar thumbnail preview" #6434 doesn't show up at all but thats another issue.
Just to be clear when this PR is merged
Dpad
-Will skip forward/backward 10s and shows the "Player seekbar thumbnail preview"
Fastforward/backward buttons
-Will skip forward/backward 10s but won't show the "Player seekbar thumbnail preview"

@ghost ghost mentioned this pull request Aug 27, 2021
4 tasks
@h-s-c
Copy link

h-s-c commented Aug 27, 2021

This works great on my Xiaomi Mi Box S. Thanks litetex!

@0metz0
Copy link

0metz0 commented Aug 29, 2021

Yes that's it. It's fixed, nice 10 sec jumps bei one tap on dpad. Thank you

@Stypox Stypox merged commit 88f1c3a into TeamNewPipe:dev Aug 30, 2021
@litetex litetex deleted the set-seekbarjump-when-using-dpad-to-seek-duration-from-preferences branch August 31, 2021 16:38
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android TV Issue is related to Android TV feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seekbar jumps on AndroidTV very long
6 participants