resets the expire date for checking for updates

[evermind-zz]

check immediately for updates if user enables 'check for updates setting'

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• reset the expire date on enable 'check for update setting"
• check immediately for updates if user enables 'check for updates setting'

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[TobiGr]

Why do you want to force an update check after restarting the app?

I think it makes sense to reset the value. However, I think NewPipe should search for updates immediately once the option was enabled.

[evermind-zz]

Why do you want to force an update check after restarting the app?

I think it makes sense to reset the value. However, I think NewPipe should search for updates immediately once the option was enabled.

sorry. I think I missed the point.
The actual behaviour is - if I recall correctly - that it is checked on app start only if the http expire header is exceeded.
With this pull-request resetting the expired timer will only force checking for new versions on restart. For me this is
good enough and very simple.

But I agree that the best way would be toggle the on/off button and then check immediately. If you would consider your idea as an mergeable pull-request I will redo the patch.

[TobiGr]

I'd merge that improvement. Go ahead :)

[evermind-zz]

I'd merge that improvement. Go ahead :)

done! please review. Thank you

[Stypox]

@evermind-zz there is no need to strikethrough the description words you removed, it just makes reading more difficult and GitHub already takes care of keeping track of the history (click on the "edited" menu)

[evermind-zz]

@evermind-zz there is no need to strikethrough the description words you removed, it just makes reading more difficult and GitHub already takes care of keeping track of the history (click on the "edited" menu)

thx for that! I've changed it

[TobiGr]

Thank you!

[evermind-zz]

Could I please request someone to finally pull this pull request? As all outstanding issues are fixed. Thank you

[litetex]

@Stypox @TobiGr
What's the state here?

[TobiGr]

Sorry, I was busy the last weeks.

Outdated