Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android Gradle Plugin to version 7.0.2 #6974

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

litetex
Copy link
Member

@litetex litetex commented Aug 25, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex marked this pull request as draft August 25, 2021 15:00
@litetex
Copy link
Member Author

litetex commented Aug 25, 2021

Update: The build requires now Java 11 so the GH-action workflows have to be adjusted

Using Java 11
@litetex litetex marked this pull request as ready for review August 25, 2021 15:20
@litetex litetex added the meta Related to the project but not strictly to code label Aug 28, 2021
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

build.gradle Outdated Show resolved Hide resolved
@AudricV AudricV changed the title Updated com.android.tools.build:gradle to 7.0.1 Update Android Gradle Plugin to version 7.0.1 Sep 11, 2021
@AudricV AudricV changed the title Update Android Gradle Plugin to version 7.0.1 Update Android Gradle Plugin to version 7.0.2 Sep 12, 2021
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can switch to building with Java 11 without problems. I already build with JDK 11

@TobiGr TobiGr merged commit 02af529 into TeamNewPipe:dev Sep 13, 2021
@litetex litetex deleted the update-android-build-tools-gradle branch September 13, 2021 17:45
@opusforlife2
Copy link
Collaborator

I did not find a changelog, too.

https://androidstudio.googleblog.com/2021/09/android-studio-arctic-fox-202031-patch.html

@litetex @TobiGr This, probably. Two issues under AGP.

This was referenced Oct 2, 2021
@Atemu
Copy link
Contributor

Atemu commented Nov 1, 2021

This breaks compat with pure IDEA without google's telemetry android flavour.

See also https://youtrack.jetbrains.com/issue/IDEA-281657

Idea users need to revert this when they want to do anything.
The AGP 4.2.2 version works just fine FYI, would it be acceptable to revert this until Idea supports AGP 7.0?

@litetex
Copy link
Member Author

litetex commented Nov 1, 2021

This breaks compat with pure IDEA without google's telemetry android flavour.

See also https://youtrack.jetbrains.com/issue/IDEA-281657

Idea users need to revert this when they want to do anything. The AGP 4.2.2 version works just fine FYI, would it be acceptable to revert this until Idea supports AGP 7.0?

This is fixed/resolved: https://youtrack.jetbrains.com/issue/IDEA-275441#focus=Comments-27-5223246.0-0

@Atemu
Copy link
Contributor

Atemu commented Nov 3, 2021

Only in the early access builds though.

It'd just be nice to be a bit more conservative with major revision bumps like these in the future then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants