Show popup menu when long pressing in play queue (Full screen player)

[ktprograms]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Added menu_play_queue_item.xml as the resource to inflate the popup menu from.
• Refactored the existing popup menu code in the background/popup player queue to use the menu xml.
• Added the popup menu code to the main player queue.

Before/After Screenshots/Screen Record

Before	After
Before.mp4	After.mp4

Fixes the following issue(s)

• Fixes UX: consistent behavior for long press in play queue #4778

APK testing

https://github.com/TeamNewPipe/NewPipe/suites/3562943169/artifacts/85514049 (Link copied from the Checks tab)

Due diligence

• I read the contribution guidelines.

[ktprograms]

Just wondering, how does the Playback Speed Menu change it's color based on device dark mode?

[Stypox]

Does the "Details" button work as expected, i.e. loading the details of another video without changing the playing stream?

[ktprograms]

I think It does change the playing stream. How can I open the details without replacing the stream?

[Stypox]

How can I open the details without replacing the stream?

I have no idea, probably it can't be done. I'd remove the "Details" action.

[ktprograms]

Good idea. Come to think of it, Details doesn't make much sense when in the main player.

[ktprograms]

@Stypox I added a setVisible(false); on the Details menu item.

[Stypox]

Thanks :-)

[ktprograms]

@Stypox all changes done in a4503eb

[ktprograms]

@Stypox I just realised, if PlayQueueActivity checks if getPlayQueue() is null, shouldn't the popup menu in Player.java also check for null since they both are returned from the same property?

[Stypox]

@ktprograms you are right, maybe it's better to make sure the play queue is not null before checking .indexOf(item) != -1, in both places

[ktprograms]

@Stypox sorry, I think I misread the code previously. The code in PlayQueueActivity checks if player is not null, not if getPlayQueue() is null:

NewPipe/app/src/main/java/org/schabi/newpipe/player/PlayQueueActivity.java

Line 326 in a4503eb

if (player != null && player.getPlayQueue().indexOf(item) != -1) {

And since I haven't had any NPE yet, I think it can just be left as it is.

[Stypox]

I tested and it works well, thank you! :-)
Btw, you can resolve conversations when you are finished implementing them, it makes navigating the thread simpler ;-)