Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-response workflow #6942

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

triallax
Copy link
Contributor

What is it?

  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add a workflow to help manage issues where the author hasn't responded to requests for more information. Here's an example:

  1. I open an issue, but it doesn't give enough information
  2. @opusforlife creates a comment asking me for the missing enough and labels the issue as waiting-for-author
  3. If I reply before 14 days, the label is automatically removed. If I reply after 14 days, the label is automatically removed and the issue is re-opened.

I opened an issue on the action's repo asking whether this works with PRs, but there's no reply yet. In any case, usage with PRs right now should be avoided, as 14 days is a far too short span of time. I plan to modify the action so we can have a separate daysUntilClose for PRs, but for now, this should be used with issues only.

I created a repo with an identical workflow to the one added in this PR. If anyone is interested in testing, feel free to ask and I'll send you an invite.

Due diligence

@triallax triallax added the meta Related to the project but not strictly to code label Aug 18, 2021
@Stypox
Copy link
Member

Stypox commented Aug 19, 2021

I'd add closeComment: false so that the issue is closed without any comment that would ping anyone involved in the thread.

@triallax
Copy link
Contributor Author

that would ping anyone involved in the thread.

It doesn't though?

If you're referring to notifications, you get a notification even if the issue is only closed, so it doesn't matter much. If you're referring to actual pinging (á la @), then the comment doesn't contain any pings by default. I think the comment is useful for clarification on why the issue was closed, but I wouldn't entirely oppose removing it if that's the consensus.

@Stypox
Copy link
Member

Stypox commented Aug 19, 2021

you get a notification even if the issue is only closed

Oh, then nevermind

@opusforlife2
Copy link
Collaborator

The run frequency should depend on how frequently the issue maintainers (mostly you) triage issues. If you do it every day, then the workflow should run every day or once in 2 days. This way, the max gap between you applying the label and the issue being closed would be 14-15 days. That is easily acceptable.

Compare this to a frequency of 5 days. The issue might get closed 19-20 days later.

@triallax
Copy link
Contributor Author

Regardless of my triaging frequency, I think once per day is good enough.

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.
Let's give it a try!

@TobiGr TobiGr merged commit 3705a1a into TeamNewPipe:dev Aug 24, 2021
@opusforlife2
Copy link
Collaborator

Odin: Unleash the Destroyer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants