Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plural forms for download related strings #6930

Merged
merged 5 commits into from
Aug 29, 2021

Conversation

Aga-C
Copy link
Contributor

@Aga-C Aga-C commented Aug 15, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • added plural form to string for downloaded files notification
  • added plural form to string for deleted files toast

Before/After Screenshots/Screen Record

There are no changes visible in English language, so I haven't done screenshots. However, changes will be visible for other languages, when translators will create new translations.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TobiGr TobiGr added bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate labels Aug 15, 2021
@Aga-C
Copy link
Contributor Author

Aga-C commented Aug 24, 2021

@TobiGr Have you seen my latest changes? Is there anything more to fix?

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@TobiGr TobiGr merged commit 43e91ae into TeamNewPipe:dev Aug 29, 2021
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing plural forms in download-related strings
2 participants