Change "not available" image from PNG to vector format #6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested on API 19 (Android 4.4) and it works only on white theme. Otherwise a gray or black background is just shown. |
|
@Stypox i just tested on virtual machine android version 4.4 api 19. i was not able to reproduce your error .
|
triallax
changed the title
triallax
changed the title
|
@sherlockbeard thank you for reconsidering this. No more boring grey background |
|
@Stypox can you give me more information about the issue and the device you are testing with |
|
@sherlockbeard I was using the emulator with 240x320:ldpi screen and Android 4.4 x86 image. But now I can't reproduce anymore. |
|
@Stypox . Ok so you are not able to reproduce so should I consider the issue (the one you mentioned in the comment) fixed? |
Stypox
approved these changes
Aug 16, 2021
|
I guess this can be merged(?) |
|
@tsiflimagas yes, I forgot about it, thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the not available .png to a xml file
Fixes #5609
fixed the issue of large devices . extension of #5925
What is it?
tablet view
