Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSV+ZIP subscriptions (Google Takeout) #6882

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

talanc
Copy link
Contributor

@talanc talanc commented Aug 9, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes #6757

Google Takeout now exports YouTube subscriptions as a CSV file (in a zip file).
This PR requires changes to NewPipeExtractor (now merged to dev).
It allows the user to select a CSV files for importing subscriptions.
If the user selects a ZIP file, it will go through the CSV files inside it and attempt to find the subscriptions file (the finding is a bit complicated due to different localizations).

Relies on the following changes

Due diligence

@talanc
Copy link
Contributor Author

talanc commented Aug 9, 2021

I've updated the instructions in strings.xml as well.
I don't know if there's an additional localization process required.
Do I just delete the old translated strings because they're displaying the wrong information?

@triallax triallax added ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug youtube Service, https://www.youtube.com/ labels Aug 9, 2021
@TobiGr
Copy link
Member

TobiGr commented Aug 10, 2021

Please update the extractor version to your fork allowing the build to complete successfully and testers to check if everything works fine.

@talanc
Copy link
Contributor Author

talanc commented Aug 10, 2021

@TobiGr
I think it's done now...
If not I'll need a bit more guidance on what to do.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this and update the extractor commit, and it is ready.

@talanc talanc changed the title Added support for CSV+ZIP subscriptions Add support for CSV+ZIP subscriptions (Google Takeout) Aug 25, 2021
@talanc
Copy link
Contributor Author

talanc commented Aug 25, 2021

@Stypox
All done.

@Stypox
Copy link
Member

Stypox commented Aug 30, 2021

@talanc I added a commit to change the way the mime type is obtained. Your solution only worked when SAF was enabled, but would throw a NullPointerException with the old file picker. Is it ok? I also squashed your commits.

@Stypox Stypox added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Aug 30, 2021
TobiGr
TobiGr previously approved these changes Aug 30, 2021
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@talanc
Copy link
Contributor Author

talanc commented Aug 30, 2021

@Stypox No problem. I was a bit unsure of that code. Thanks for improving it.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Aug 30, 2021
@Stypox Stypox merged commit f8f2dfc into TeamNewPipe:dev Aug 31, 2021
@Stypox
Copy link
Member

Stypox commented Aug 31, 2021

Thank you @talanc :-D

This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug youtube Service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YouTube subscriptions cannot be imported (seem to be exported as .csv now)
4 participants