-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CSV+ZIP subscriptions (Google Takeout) #6882
Conversation
I've updated the instructions in strings.xml as well. |
Please update the extractor version to your fork allowing the build to complete successfully and testers to check if everything works fine. |
@TobiGr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this and update the extractor commit, and it is ready.
@Stypox |
@talanc I added a commit to change the way the mime type is obtained. Your solution only worked when SAF was enabled, but would throw a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
@Stypox No problem. I was a bit unsure of that code. Thanks for improving it. |
Updated import instructions string
Thank you @talanc :-D |
What is it?
Description of the changes in your PR
Fixes #6757
Google Takeout now exports YouTube subscriptions as a CSV file (in a zip file).
This PR requires changes to NewPipeExtractor (now merged to dev).
It allows the user to select a CSV files for importing subscriptions.
If the user selects a ZIP file, it will go through the CSV files inside it and attempt to find the subscriptions file (the finding is a bit complicated due to different localizations).
Relies on the following changes
Due diligence