Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name the regions according to the comments #6854

Merged

Conversation

evermind-zz
Copy link
Contributor

@evermind-zz evermind-zz commented Aug 5, 2021

this pull request replaces #6512

if a region is named android studio will show its name in the structure view.

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • increase readabilty in android studio structure view

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

if a region is named android studio will show its name in the structure view.
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@triallax
Copy link
Contributor

triallax commented Aug 8, 2021

Are the decorative and large comments above the region comments necessary anymore? They look just like boilerplate to me now.

@Stypox
Copy link
Member

Stypox commented Aug 9, 2021

Are the decorative and large comments above the region comments necessary anymore? They look just like boilerplate to me now.

I personally use them to navigate, especially in GitHub where there is no folding behaviour (or even on Android Studio when I'm too lazy to press the buttons to fold ;-))

@triallax
Copy link
Contributor

triallax commented Aug 9, 2021

If you say so...

@triallax triallax merged commit a536311 into TeamNewPipe:dev Aug 10, 2021
@triallax
Copy link
Contributor

Thanks!

@evermind-zz evermind-zz deleted the make-regions-visible-in-android-studio branch August 18, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants