Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play queue theme #6847

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Aug 4, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Change the Play Queue activity to match the theme of the selected service.

Before/After Screenshots/Screen Record

With SoundCloud selected:

Before After

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Stypox Stypox mentioned this pull request Aug 4, 2021
5 tasks
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Aug 4, 2021

Unfortunately, this PR doesn't work for me. This is how the UI looks in both #6847 and #6841 apk files.

Screen Recording
Screenrecorder-2021-08-04-22-24-57-250.mp4

@skyGtm
Copy link

skyGtm commented Aug 4, 2021

@Stypox I think you forgot to commit the code part.
The 'Files Changed' tab is showing 'version bump' and 'changelog' files only.

This might be the reason it's not working @SameenAhnaf

@Stypox Stypox changed the base branch from dev to release_0.21.9 August 4, 2021 16:41
@Stypox
Copy link
Member Author

Stypox commented Aug 4, 2021

@skyGtm @SameenAhnaf I am stupid, sorry for wasting your time. I've pushed the correct code now...

@triallax triallax added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Aug 4, 2021
@skyGtm
Copy link

skyGtm commented Aug 4, 2021

Its working for me.
Play Queue theme is same as that of selected service. 🎉 🎉 🎉

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Aug 4, 2021

Thanks. It's working now.

@litetex
Copy link
Member

litetex commented Aug 4, 2021

Description of the changes in your PR

  • record videos
  • create clones
  • take over the world

👀

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TobiGr TobiGr merged commit c3349e1 into TeamNewPipe:release_0.21.9 Aug 4, 2021
@Stypox Stypox mentioned this pull request Aug 5, 2021
@Stypox Stypox deleted the play-queue-theme branch August 4, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants