-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some AndroidX libraries #6719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read the changelogs and could not find anything that could break NewPipe, though I do not know enough about AndroidX libraries.
assuming further appCompat versions will also update it's transitive dependencies to recommended versions, would anything be speaking against removing the dependencies to core and lifecycle completely from the build.gradle? Would make future updates easier / require less maintenance for the dependencies. |
I would probably recommend keeping them, as they can also be updated separately, and allow for usage of Kotlin extensions as well (core-ktx, lifecycle ktx, etc.). And sometimes lower transitive versions are used if specific versions are not specified in the dependency block. |
AndroidX AppCompat 1.3.1 and AndroidX Fragment 1.3.6 came out today, so I'll include those in this PR as they're just bugfix releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Redirion merge this if you think it looks fine
What is it?
Description of the changes in your PR
This PR is meant as a follow up to #6702.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence