Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kotlin methods in LicenseFragment. #6675

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Make use of Kotlin methods, such as the let block, in LicenseFragment.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Jul 17, 2021
@Stypox
Copy link
Member

Stypox commented Jul 19, 2021

Thank you! The code is equivalent; I tested and it works

@Stypox Stypox merged commit ca282f2 into TeamNewPipe:dev Jul 19, 2021
@Isira-Seneviratne Isira-Seneviratne deleted the Use_Kotlin_methods branch July 19, 2021 14:16
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants